fix: Capture GCP HTTP errors in MCP Toolbox#2347
Conversation
Summary of ChangesHello @mahlevanshika, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the robustness and clarity of error handling within the Dataplex source integration. It ensures that when interactions with the Dataplex API encounter issues, the resulting errors are more informative, specifically by detailing gRPC status codes and messages. This enhancement is crucial for debugging and understanding the root cause of API failures, leading to a more stable and maintainable system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix GCP HTTP errors in the Dataplex source. The changes correctly introduce more robust error handling for iterator operations, checking for iterator.Done and handling other errors, including specific gRPC status errors.
However, the pull request contains unresolved merge conflicts in internal/sources/dataplex/dataplex.go, which are critical issues that must be resolved. I've left comments on the conflicting blocks with suggestions on how to resolve them and further improve the error handling by ensuring errors are always wrapped to preserve context.
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
…vanshika/genai-toolbox into fix/issue-2203-mcp-gcp-http-errors
|
/gcbrun |
Head branch was pushed to by a user without write access
|
/gcbrun |
### Description fix: Surface Dataplex API errors in MCP results This change addresses issue googleapis#2203, where Dataplex API errors, such as '403 Forbidden' (Permission Denied), were not being properly surfaced in the MCP tool results. Previously, these critical API errors would manifest as generic "connection interrupted" messages, significantly hindering developer debugging and trust in the Toolbox. The fix enhances the error handling within the 'dataplexsearchentries' and 'dataplexsearchaspecttypes' tools. When an error occurs during the iteration of Dataplex API results, the system now: Utilizes 'google.golang.org/grpc/status.FromError' to attempt to convert the returned error into a gRPC status. This is crucial because Google Cloud client libraries often return errors compatible with gRPC. If the error is a gRPC status, the canonical error code (e.g., 'codes.PermissionDenied') and the associated error message are extracted. This ensures that users receive clear actionable error feedback, allowing for quicker diagnosis and resolution of issues like missing IAM permissions. This aligns with best practices for API error surfacing, improving the usability and reliability of the Dataplex tools within the GenAI Toolbox. Fixes googleapis#2203 ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.27.0](v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([#1987](#1987)) ([478a0bd](478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([#2353](#2353)) ([6e49ba4](6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([#2392](#2392)) ([80ef346](80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([#2137](#2137)) ([252fc30](252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([#2006](#2006)) ([1fdd99a](1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([#2340](#2340)) ([e995349](e995349)) * **server:** Add Tool call error categories ([#2387](#2387)) ([32cb4db](32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([#2430](#2430)) ([a15a128](a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([#2347](#2347)) ([1d7c498](1d7c498)) * **sources/cockroachdb:** Update kind to type ([#2465](#2465)) ([2d341ac](2d341ac)) * Surface Dataplex API errors in MCP results ([#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.27.0](v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([#1987](#1987)) ([478a0bd](478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([#2353](#2353)) ([6e49ba4](6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([#2392](#2392)) ([80ef346](80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([#2137](#2137)) ([252fc30](252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([#2006](#2006)) ([1fdd99a](1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([#2340](#2340)) ([e995349](e995349)) * **server:** Add Tool call error categories ([#2387](#2387)) ([32cb4db](32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([#2430](#2430)) ([a15a128](a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([#2347](#2347)) ([1d7c498](1d7c498)) * **sources/cockroachdb:** Update kind to type ([#2465](#2465)) ([2d341ac](2d341ac)) * Surface Dataplex API errors in MCP results ([#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c5524d3
🤖 I have created a release *beep* *boop* --- ## [0.27.0](googleapis/mcp-toolbox@v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([googleapis#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([googleapis#1987](googleapis#1987)) ([478a0bd](googleapis@478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([googleapis#2353](googleapis#2353)) ([6e49ba4](googleapis@6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([googleapis#2392](googleapis#2392)) ([80ef346](googleapis@80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([googleapis#2137](googleapis#2137)) ([252fc30](googleapis@252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([googleapis#2006](googleapis#2006)) ([1fdd99a](googleapis@1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([googleapis#2340](googleapis#2340)) ([e995349](googleapis@e995349)) * **server:** Add Tool call error categories ([googleapis#2387](googleapis#2387)) ([32cb4db](googleapis@32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([googleapis#2430](googleapis#2430)) ([a15a128](googleapis@a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([googleapis#2347](googleapis#2347)) ([1d7c498](googleapis@1d7c498)) * **sources/cockroachdb:** Update kind to type ([googleapis#2465](googleapis#2465)) ([2d341ac](googleapis@2d341ac)) * Surface Dataplex API errors in MCP results ([googleapis#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c5524d3
🤖 I have created a release *beep* *boop* --- ## [0.27.0](googleapis/mcp-toolbox@v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([googleapis#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([googleapis#1987](googleapis#1987)) ([478a0bd](googleapis@478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([googleapis#2353](googleapis#2353)) ([6e49ba4](googleapis@6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([googleapis#2392](googleapis#2392)) ([80ef346](googleapis@80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([googleapis#2137](googleapis#2137)) ([252fc30](googleapis@252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([googleapis#2006](googleapis#2006)) ([1fdd99a](googleapis@1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([googleapis#2340](googleapis#2340)) ([e995349](googleapis@e995349)) * **server:** Add Tool call error categories ([googleapis#2387](googleapis#2387)) ([32cb4db](googleapis@32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([googleapis#2430](googleapis#2430)) ([a15a128](googleapis@a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([googleapis#2347](googleapis#2347)) ([1d7c498](googleapis@1d7c498)) * **sources/cockroachdb:** Update kind to type ([googleapis#2465](googleapis#2465)) ([2d341ac](googleapis@2d341ac)) * Surface Dataplex API errors in MCP results ([googleapis#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c5524d3
🤖 I have created a release *beep* *boop* --- ## [0.27.0](v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([#1987](#1987)) ([478a0bd](478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([#2353](#2353)) ([6e49ba4](6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([#2392](#2392)) ([80ef346](80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([#2137](#2137)) ([252fc30](252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([#2006](#2006)) ([1fdd99a](1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([#2340](#2340)) ([e995349](e995349)) * **server:** Add Tool call error categories ([#2387](#2387)) ([32cb4db](32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([#2430](#2430)) ([a15a128](a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([#2347](#2347)) ([1d7c498](1d7c498)) * **sources/cockroachdb:** Update kind to type ([#2465](#2465)) ([2d341ac](2d341ac)) * Surface Dataplex API errors in MCP results ([#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.27.0](googleapis/mcp-toolbox@v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([googleapis#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([googleapis#1987](googleapis#1987)) ([478a0bd](googleapis@478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([googleapis#2353](googleapis#2353)) ([6e49ba4](googleapis@6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([googleapis#2392](googleapis#2392)) ([80ef346](googleapis@80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([googleapis#2137](googleapis#2137)) ([252fc30](googleapis@252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([googleapis#2006](googleapis#2006)) ([1fdd99a](googleapis@1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([googleapis#2340](googleapis#2340)) ([e995349](googleapis@e995349)) * **server:** Add Tool call error categories ([googleapis#2387](googleapis#2387)) ([32cb4db](googleapis@32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([googleapis#2430](googleapis#2430)) ([a15a128](googleapis@a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([googleapis#2347](googleapis#2347)) ([1d7c498](googleapis@1d7c498)) * **sources/cockroachdb:** Update kind to type ([googleapis#2465](googleapis#2465)) ([2d341ac](googleapis@2d341ac)) * Surface Dataplex API errors in MCP results ([googleapis#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
### Description fix: Surface Dataplex API errors in MCP results This change addresses issue googleapis#2203, where Dataplex API errors, such as '403 Forbidden' (Permission Denied), were not being properly surfaced in the MCP tool results. Previously, these critical API errors would manifest as generic "connection interrupted" messages, significantly hindering developer debugging and trust in the Toolbox. The fix enhances the error handling within the 'dataplexsearchentries' and 'dataplexsearchaspecttypes' tools. When an error occurs during the iteration of Dataplex API results, the system now: Utilizes 'google.golang.org/grpc/status.FromError' to attempt to convert the returned error into a gRPC status. This is crucial because Google Cloud client libraries often return errors compatible with gRPC. If the error is a gRPC status, the canonical error code (e.g., 'codes.PermissionDenied') and the associated error message are extracted. This ensures that users receive clear actionable error feedback, allowing for quicker diagnosis and resolution of issues like missing IAM permissions. This aligns with best practices for API error surfacing, improving the usability and reliability of the Dataplex tools within the GenAI Toolbox. Fixes googleapis#2203 ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.27.0](googleapis/mcp-toolbox@v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([googleapis#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([googleapis#1987](googleapis#1987)) ([478a0bd](googleapis@478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([googleapis#2353](googleapis#2353)) ([6e49ba4](googleapis@6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([googleapis#2392](googleapis#2392)) ([80ef346](googleapis@80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([googleapis#2137](googleapis#2137)) ([252fc30](googleapis@252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([googleapis#2006](googleapis#2006)) ([1fdd99a](googleapis@1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([googleapis#2340](googleapis#2340)) ([e995349](googleapis@e995349)) * **server:** Add Tool call error categories ([googleapis#2387](googleapis#2387)) ([32cb4db](googleapis@32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([googleapis#2430](googleapis#2430)) ([a15a128](googleapis@a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([googleapis#2347](googleapis#2347)) ([1d7c498](googleapis@1d7c498)) * **sources/cockroachdb:** Update kind to type ([googleapis#2465](googleapis#2465)) ([2d341ac](googleapis@2d341ac)) * Surface Dataplex API errors in MCP results ([googleapis#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.27.0](googleapis/mcp-toolbox@v0.26.0...v0.27.0) (2026-02-12) ### ⚠ BREAKING CHANGES * Update configuration file v2 ([#2369](https://github.com/googleapis/genai-toolbox/issues/2369))([293c1d6](https://github.com/googleapis/genai-toolbox/commit/293c1d6889c39807855ba5e01d4c13ba2a4c50ce)) * Update/add detailed telemetry for mcp endpoint compliant with OTEL semantic convention ([#1987](googleapis/mcp-toolbox#1987)) ([478a0bd](googleapis/mcp-toolbox@478a0bd)) ### Features * **cli/invoke:** Add support for direct tool invocation from CLI ([#2353](googleapis/mcp-toolbox#2353)) ([6e49ba4](googleapis/mcp-toolbox@6e49ba4)) * **cli/skills:** Add support for generating agent skills from toolset ([#2392](googleapis/mcp-toolbox#2392)) ([80ef346](googleapis/mcp-toolbox@80ef346)) * **cloud-logging-admin:** Add source, tools, integration test and docs ([#2137](googleapis/mcp-toolbox#2137)) ([252fc30](googleapis/mcp-toolbox@252fc30)) * **cockroachdb:** Add CockroachDB integration with cockroach-go ([#2006](googleapis/mcp-toolbox#2006)) ([1fdd99a](googleapis/mcp-toolbox@1fdd99a)) * **prebuiltconfigs/alloydb-omni:** Implement Alloydb omni dataplane tools ([#2340](googleapis/mcp-toolbox#2340)) ([e995349](googleapis/mcp-toolbox@e995349)) * **server:** Add Tool call error categories ([#2387](googleapis/mcp-toolbox#2387)) ([32cb4db](googleapis/mcp-toolbox@32cb4db)) * **tools/looker:** support `looker-validate-project` tool ([#2430](googleapis/mcp-toolbox#2430)) ([a15a128](googleapis/mcp-toolbox@a15a128)) ### Bug Fixes * **dataplex:** Capture GCP HTTP errors in MCP Toolbox ([#2347](googleapis/mcp-toolbox#2347)) ([1d7c498](googleapis/mcp-toolbox@1d7c498)) * **sources/cockroachdb:** Update kind to type ([#2465](googleapis/mcp-toolbox#2465)) ([2d341ac](googleapis/mcp-toolbox@2d341ac)) * Surface Dataplex API errors in MCP results ([#2347](https://github.com/googleapis/genai-toolbox/pull/2347))([1d7c498](https://github.com/googleapis/genai-toolbox/commit/1d7c4981164c34b4d7bc8edecfd449f57ad11e15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
Description
fix: Surface Dataplex API errors in MCP results
This change addresses issue #2203, where Dataplex API errors, such as '403 Forbidden' (Permission Denied), were not being properly surfaced in the MCP tool results. Previously, these critical API errors would manifest as generic "connection interrupted" messages, significantly hindering developer debugging and trust in the Toolbox.
The fix enhances the error handling within the 'dataplexsearchentries' and 'dataplexsearchaspecttypes' tools. When an error occurs during the iteration of Dataplex API results, the system now:
Utilizes 'google.golang.org/grpc/status.FromError' to attempt to convert the returned error into a gRPC status. This is crucial because Google Cloud client libraries often return errors compatible with gRPC.
If the error is a gRPC status, the canonical error code (e.g., 'codes.PermissionDenied') and the associated error message are extracted.
This ensures that users receive clear actionable error feedback, allowing for quicker diagnosis and resolution of issues like missing IAM permissions. This aligns with best practices for API error surfacing, improving the usability and reliability of the Dataplex tools within the GenAI Toolbox.
Fixes #2203
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>