Docs: Add link to pages in contribution guide#983
Merged
antongolub merged 8 commits intogoogle:mainfrom Dec 15, 2024
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
antongolub
requested changes
Dec 15, 2024
docs/contributing.md
Outdated
| just a few small guidelines you need to follow. | ||
| ## Disclaimer | ||
|
|
||
| This is a snapshot of a contribution guide. |
Collaborator
There was a problem hiding this comment.
# Contribution Guide
zx is a fully [open-source project](https://github.com/google/zx), which is developing by the community for the community.
We welcome contributions of any kind, including but not limited to:
* Bug reports
* Feature requests
* Code contributions
* Documentation improvements
* Discussions
https://google.github.io/zx/contribution
Contributor
Author
There was a problem hiding this comment.
Moved the link, removed the disclaimer
antongolub
requested changes
Dec 15, 2024
docs/contributing.md
Outdated
| * Create a [conventional-commits](https://www.conventionalcommits.org/en/v1.0.0/) compliant messages. | ||
| * Ensure that everything is working: | ||
| * `npm run fmt` to format your code. | ||
| * `npm run cov` to run the tests. |
Collaborator
There was a problem hiding this comment.
npm run cov > npm test
Contributor
There was a problem hiding this comment.
npm run cov not exist. Maybe npm run test:coverage ?
Contributor
Author
There was a problem hiding this comment.
Thanks!
Changed that
antongolub
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #982