Skip to content

fix(cli): always check if tempfile exists#1041

Merged
antongolub merged 2 commits intogoogle:mainfrom
antongolub:fix-cli-tempfile
Dec 26, 2024
Merged

fix(cli): always check if tempfile exists#1041
antongolub merged 2 commits intogoogle:mainfrom
antongolub:fix-cli-tempfile

Conversation

@antongolub
Copy link
Copy Markdown
Collaborator

@antongolub antongolub commented Dec 25, 2024

What's wrong now:

  • Processing readme.md may override existing user's local readme.md.mjs
  • Markdown flow ignores --ext and applies .mjs everytime, so cjs contents fails.
  • Fetching from https ignores --ext option too: https://example.com/path/script.js.bak calls <temp>script.js.bak instead of <temp>script.js.mjs
  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub requested a review from antonmedv December 25, 2024 22:37
@antongolub antongolub changed the title fix(cli): always check if tempfile exist fix(cli): always check if tempfile exists Dec 26, 2024
@antongolub antongolub merged commit 6ecbad2 into google:main Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant