Skip to content

Skip Anneal benchmark storage outside canonical main#3452

Merged
joshlf merged 1 commit into
mainfrom
codex/fix-job-failure-on-forked-repo
Jun 8, 2026
Merged

Skip Anneal benchmark storage outside canonical main#3452
joshlf merged 1 commit into
mainfrom
codex/fix-job-failure-on-forked-repo

Conversation

@joshlf

@joshlf joshlf commented Jun 8, 2026

Copy link
Copy Markdown
Member

Motivation

  • Prevent the Anneal workflow from attempting to publish benchmark data when the run is not a trusted push to the canonical repository (e.g., fork/PR runs) which can fail due to read-only GITHUB_TOKEN or insufficient permissions.

Description

  • Restrict the "Store CI duration benchmarks" step by adding if: github.event_name == 'push' && github.repository == 'google/zerocopy' && github.ref == 'refs/heads/main' and make save-data-file: true so only trusted main-branch pushes publish benchmark history.

Testing

  • Verified YAML parsing with ruby -e 'require "yaml"; YAML.load_file(".github/workflows/anneal.yml")' (succeeded), linting with go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/anneal.yml (succeeded), and git diff --check (succeeded), while a Python YAML load using PyYAML could not be run in the environment due to missing PyYAML (failed).

Codex Task

@joshlf joshlf enabled auto-merge June 8, 2026 14:23

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (7055b34) to head (523d937).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3452   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 88536c1 Jun 8, 2026
131 checks passed
@joshlf joshlf deleted the codex/fix-job-failure-on-forked-repo branch June 8, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants