Conversation
This seems to speed things up significantly, resulting e.g. in [1] taking 3m34s (with a cache hit, skipping the "Generate cache" step). [1] https://github.com/google/zerocopy/actions/runs/19657114158
When generating the cache, if there's a cache hit, don't download the cache. Previously, we would download the cache and *then* check for a cache hit.
Modify the `cargo-zerocopy` tool: - To set `CARGO_TARGET_DIR` to a toolchain-specific directory inside of `target/` so that different toolchains won't clobber each others' artifacts - To auto-install toolchains and toolchain components via `rustup` without prompting for user input when running from a GitHub Actions environment This allows us to remove an explicit install step during CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 20 20
Lines 5450 5450
=======================================
Hits 4804 4804
Misses 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4c40d6b to
ffb9dc8
Compare
jswrenn
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2822, factoring out most of its optimizations while avoiding the ones that turned out to be overly complex without much performance benefit.
Brings the execution time to 3m20s when there's a cache hit.