fix(local): log and preserve package count before continuing on db error#2126
Merged
hogo6002 merged 1 commit intogoogle:mainfrom Aug 1, 2025
Merged
fix(local): log and preserve package count before continuing on db error#2126hogo6002 merged 1 commit intogoogle:mainfrom
hogo6002 merged 1 commit intogoogle:mainfrom
Conversation
hogo6002
approved these changes
Jul 30, 2025
7e38cb3 to
7e07971
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2126 +/- ##
=======================================
Coverage 67.58% 67.58%
=======================================
Files 170 170
Lines 16148 16151 +3
=======================================
+ Hits 10913 10916 +3
Misses 4569 4569
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7e07971 to
03e10f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results from
MatchVulnerabilitiesis expected to have the same items as packages that were provided but currently if the database cannot be loaded (such as because we're using an ecosystem that does not have a database available) we just "continue" resulting in off-by-n errors further down the line