Skip to content

feat: support ubutnu severity type#2076

Merged
hogo6002 merged 5 commits intogoogle:mainfrom
hogo6002:fix_ubuntu_severity
Jul 16, 2025
Merged

feat: support ubutnu severity type#2076
hogo6002 merged 5 commits intogoogle:mainfrom
hogo6002:fix_ubuntu_severity

Conversation

@hogo6002
Copy link
Copy Markdown
Contributor

@hogo6002 hogo6002 commented Jul 15, 2025

Resolves #1964

Note: some Ubuntu records have moved their priority tags from ecosystem-specific to severity fields, but osv.dev has failed to provide a correct severity type. For now, we check both empty severity tags and Ubuntu severity tags to see if a vulnerability has been marked as ineligible

}
},
"vulnerabilities": [
"UBUNTU-CVE-2022-3219",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like is caused by upstream ordering? Do we put the one with the most amount of upstream at the top or the one with the least upstream at the top? UBUNTU-CVE-2022-3219 recently added an upstream field. But i think we wanted to put USN at the top, right? @jess-lowe

@hogo6002 hogo6002 marked this pull request as ready for review July 16, 2025 01:08
@hogo6002 hogo6002 requested review from another-rex and cuixq July 16, 2025 01:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.06%. Comparing base (3eceb8a) to head (ba74167).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/utility/severity/severity.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2076   +/-   ##
=======================================
  Coverage   66.05%   66.06%           
=======================================
  Files         172      172           
  Lines       16192    16200    +8     
=======================================
+ Hits        10696    10702    +6     
- Misses       4846     4848    +2     
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's just try removing the extra ignore I added last week.

@hogo6002 hogo6002 merged commit 0545b9f into google:main Jul 16, 2025
17 checks passed
@hogo6002 hogo6002 mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Ubuntu unimportant filter

4 participants