Skip to content

feat(output): add summary section at the top of outputs#2032

Merged
hogo6002 merged 13 commits intogoogle:mainfrom
Aejkatappaja:f/output_table/vuln_view
Jul 17, 2025
Merged

feat(output): add summary section at the top of outputs#2032
hogo6002 merged 13 commits intogoogle:mainfrom
Aejkatappaja:f/output_table/vuln_view

Conversation

@Aejkatappaja
Copy link
Copy Markdown
Contributor

@Aejkatappaja Aejkatappaja commented Jul 7, 2025 •
edited
Loading

#2025

  • Add summary section at the top of outputs.
  • Add 'Fixed Version' column.
  • Updates documentation (docs/output.md) to reflect these changes.
  • Updates test snapshots for the new output format.

@cuixq cuixq requested a review from hogo6002 July 8, 2025 00:17
@cuixq
Copy link
Copy Markdown
Contributor

cuixq commented Jul 8, 2025

I am a bit worried about the table being too wide with the summary added, but will leave @hogo6002 to further comment on this.

@hogo6002
Copy link
Copy Markdown
Contributor

hogo6002 commented Jul 8, 2025

Thanks for contributing!

The summary I'm referring to isn't about adding a new column to display vulnerability details. Instead, I meant to include a summary section at the top of the table output, listing the total number of vulnerabilities found during the scan.

@Aejkatappaja
Copy link
Copy Markdown
Contributor Author

Aejkatappaja commented Jul 8, 2025

@hogo6002 thanks for the clarifications !
I'll fix it !

@Aejkatappaja Aejkatappaja changed the title feat(output): add 'Fixed Version' and 'Summary' columns to table output feat(output): add summary section at the top of outputs Jul 8, 2025
@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from 9dddfbd to 93ba8fb Compare July 8, 2025 08:16
@Aejkatappaja
Copy link
Copy Markdown
Contributor Author

Aejkatappaja commented Jul 8, 2025

@hogo6002 i made some changes regarding your comment

@hogo6002
Copy link
Copy Markdown
Contributor

hogo6002 commented Jul 9, 2025

Thanks for adding the summary. For the fixed version one, I still prefer to keep the fixed version column like your initial version.

@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from 4c522ec to d1855dc Compare July 9, 2025 11:02
hogo6002
hogo6002 reviewed Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment. Thanks!

@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from 6e9e649 to e768d15 Compare July 10, 2025 09:34
hogo6002
hogo6002 reviewed Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from 35872ce to 858a28f Compare July 11, 2025 07:35
hogo6002
hogo6002 approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hogo6002
Copy link
Copy Markdown
Contributor

hogo6002 commented Jul 14, 2025

Hi, can you run ./scripts/run_formatters.sh to fix the format. Also update branch and resolve conflicts by updating test snaps again?

@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from e5a5819 to df1727c Compare July 14, 2025 07:12
@Aejkatappaja
Copy link
Copy Markdown
Contributor Author

Aejkatappaja commented Jul 14, 2025

Hi, can you run ./scripts/run_formatters.sh to fix the format. Also update branch and resolve conflicts by updating test snaps again?

Done ✅

@hogo6002
Copy link
Copy Markdown
Contributor

hogo6002 commented Jul 16, 2025

Hey, can you re-run all tests again? some new vuln has been found, so it would require updating the snapshots again.

@Aejkatappaja
fix(output): align table/markdown output and doc with reviewer feedback
bc551a4 
- Remove 'Fixed Version' and 'Summary' columns from table/markdown
outputs
- Add summary section at the top of outputs
- Mark advisories without a fix with '*' in OSV URL
- Update documentation and examples accordingly
@Aejkatappaja
refactor(table): add a FIXED VERSION column
d08e14a 
- Remove 'Fixed Version' and 'Summary' columns from table/markdown
outputs
- Add summary section at the top of outputs
- Mark advisories without a fix with '*' in OSV URL
- Update documentation and examples accordingly
@Aejkatappaja
refactor(doc): remove * to columns without a fix
79e2175
@Aejkatappaja
refactor(table): remove * logic on link
3383ba8
@Aejkatappaja
refactor(snapshots): update
e7aba48
@Aejkatappaja
refactor(output-result): replace UnfixedDescription label by "--"
b60776e
@Aejkatappaja
refactor(output_result): revert label change
9a99816
@Aejkatappaja
refactor(markdowntable): correct comments
37bd14a
@Aejkatappaja
refactor(table): rework fixed version display logic
af43309
@Aejkatappaja
refactor(snapshots): bump
ba9dc84
@Aejkatappaja
refactor(chore): update branch / update tests snaps
8d560ba
@Aejkatappaja Aejkatappaja force-pushed the f/output_table/vuln_view branch from 7901bfb to 8d560ba Compare July 16, 2025 06:49
@Aejkatappaja
Copy link
Copy Markdown
Contributor Author

Aejkatappaja commented Jul 16, 2025

Hey, can you re-run all tests again? some new vuln has been found, so it would require updating the snapshots again.

Done ✅

@Aejkatappaja Aejkatappaja requested a review from hogo6002 July 16, 2025 07:06
@Aejkatappaja
Copy link
Copy Markdown
Contributor Author

Aejkatappaja commented Jul 16, 2025

@hogo6002 @cuixq
Hi, I don’t understand why the unit tests are failing in CI for my PR?
I’ve already updated the snapshots, and all tests pass locally.

Could someone help me figure out what’s going wrong? Thanks!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.51%. Comparing base (e3795bd) to head (9dd4acf).
⚠️ Report is 453 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   67.49%   67.51%   +0.02%     
==========================================
  Files         172      172              
  Lines       16231    16242      +11     
==========================================
+ Hits        10955    10966      +11     
  Misses       4601     4601              
  Partials      675      675

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq
Copy link
Copy Markdown
Contributor

cuixq commented Jul 16, 2025

@Aejkatappaja I think it was due to some testing data change, it is fixed now.

@hogo6002 hogo6002 merged commit 95d840a into google:main Jul 17, 2025
17 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hogo6002 hogo6002 Awaiting requested review from hogo6002

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aejkatappaja @cuixq @hogo6002 @codecov-commenter