Skip to content

Improved the runtime of DiffVulnerabilityResults#1091

Merged
another-rex merged 3 commits intogoogle:mainfrom
neilnaveen:neil/speedupDiffVulnerabilityResults
Jul 12, 2024
Merged

Improved the runtime of DiffVulnerabilityResults#1091
another-rex merged 3 commits intogoogle:mainfrom
neilnaveen:neil/speedupDiffVulnerabilityResults

Conversation

@neilnaveen
Copy link
Copy Markdown
Contributor

  • Improved the runtime of DiffVulnerabilityResults
  • Precomputed the existence of Sources, Packages, and Vulnerabilities, which brings the time complexity down from O(n^2) to O(n).

- Improved the runtime of DiffVulnerabilityResults
- Precomputed the existence of Sources, Packages, and Vulnerabilities, which brings the time complexity down from O(n^2) to O(n).
@neilnaveen neilnaveen requested a review from cuixq July 9, 2024 15:47
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 10, 2024

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.01%. Comparing base (e35bd05) to head (43a04e4).
⚠️ Report is 772 commits behind head on main.

Files with missing lines Patch % Lines
internal/ci/vulnerability_result_diff.go 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   65.94%   66.01%   +0.06%     
==========================================
  Files         159      159              
  Lines       12758    12784      +26     
==========================================
+ Hits         8413     8439      +26     
  Misses       3885     3885              
  Partials      460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@another-rex another-rex merged commit 45fb6f9 into google:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants