Skip to content

chore(deps): bump typescript version#859

Merged
alexander-fenster merged 1 commit into
google:mainfrom
tonycoco:typescript_version_bump
Mar 21, 2024
Merged

chore(deps): bump typescript version#859
alexander-fenster merged 1 commit into
google:mainfrom
tonycoco:typescript_version_bump

Conversation

@tonycoco

Copy link
Copy Markdown
Collaborator

Fixes #853

@ddelgrosso1 ddelgrosso1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will defer to others to see if they have any objections.

@ddelgrosso1 ddelgrosso1 assigned ddelgrosso1 and sofisl and unassigned ddelgrosso1 Mar 21, 2024
@ddelgrosso1 ddelgrosso1 self-requested a review March 21, 2024 17:49
@ddelgrosso1

ddelgrosso1 commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Just noticed the commit message, I'm not sure why this repo isn't enforcing it but it should follow conventional commits, something like chore(deps): bump typescript version

@tonycoco tonycoco force-pushed the typescript_version_bump branch from a8bd648 to c4c2aac Compare March 21, 2024 18:05
@tonycoco

Copy link
Copy Markdown
Collaborator Author

Fixed commit-msg.

@tonycoco tonycoco changed the title Bumps TypeScript version to ~5.4.3 chore(deps): bump typescript version Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript version warning

4 participants