Add iterator fail-fast tests for LinkedTreeMap.clear()#2992
Merged
eamonnmcmanus merged 6 commits intoMar 10, 2026
Conversation
Removed multiple test cases for clearing LinkedTreeMap, including tests for single and multiple entries, null values, and various scenarios.
Removed unnecessary blank line in LinkedTreeMapTest.
eamonnmcmanus
approved these changes
Mar 10, 2026
eamonnmcmanus
left a comment
Member
There was a problem hiding this comment.
Thanks, this makes sense!
utsavatwork
pushed a commit
to utsavatwork/gson
that referenced
this pull request
Mar 12, 2026
* Add boundary tests for JsonTreeWriter.endArray() error handling * Add comprehensive boundary tests for LinkedTreeMap.clear() method * Update JsonTreeWriterTest.java * Remove redundant clear map tests from LinkedTreeMapTest Removed multiple test cases for clearing LinkedTreeMap, including tests for single and multiple entries, null values, and various scenarios. * Remove blank line in LinkedTreeMapTest Removed unnecessary blank line in LinkedTreeMapTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add iterator fail-fast validation tests for LinkedTreeMap.clear() method.
Why
The clear() method increments modCount to ensure existing iterators become invalid after the map is cleared. This is a critical fail-fast contract that prevents silent data corruption during iteration.
The added tests verify that:
These tests ensure the fail-fast mechanism remains intact, which is essential for preventing concurrent modification bugs in production code.
Verification
Ran mvn -pl gson -Dtest=LinkedTreeMapTest
Result: all tests passed