Add shrinker test for interface implementation being deserialized#2845
Merged
eamonnmcmanus merged 1 commit intogoogle:mainfrom Apr 16, 2025
Merged
Conversation
For R8 this currently fails, see TODOs in the new code.
2 tasks
|
@Marcono1234 Yep, that setup matches my usage. |
Contributor
Author
Yes that would be great, thanks! Contact details are here: https://r8.googlesource.com/r8#getting-help (in case you didn't know that already). |
Contributor
Author
|
@eamonnmcmanus, do you think we can merge this here already to have a test case for it? (even if it currently has special handling for the R8 failure) |
eamonnmcmanus
approved these changes
Apr 16, 2025
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Yes, that makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shrinker test which tries to replicate the issue described in #2658.
@alipov, could you please check whether this test, specifically
InterfaceWithImplementationand the usage intestDeserializingInterfaceImplrepresents the setup you are using?For R8 this currently fails, see TODOs in the new code. Not sure if there is something Gson can do at the moment, without making
gson.prounconditionally keep classes with@SerializedNameregardless of whether they are used (which is probably something we want to avoid?). Also note that this might be an uncommon corner case.Maybe this is actually an R8 bug or limitation.