Throw exception when calling JsonWriter.name outside JSON object#2476
Merged
eamonnmcmanus merged 2 commits intogoogle:mainfrom Aug 29, 2023
Merged
Conversation
9 tasks
JsonWriter.name outside objectJsonWriter.name outside JSON object
Previous fix in 392cc65 only covered writing name as top level value, but not when trying to write name inside JSON array. Removed `stackSize == 0` check from `JsonWriter.name` because that is done already by `peek()` call.
ad9abcf to
07c38bc
Compare
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
…oogle#2476) Previous fix in 392cc65 only covered writing name as top level value, but not when trying to write name inside JSON array. Removed `stackSize == 0` check from `JsonWriter.name` because that is done already by `peek()` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up for #2475
Closes #2407
Description
Previous fix in #2475 only covered writing name as top level value, but not when trying to write name inside JSON array.
Checklist
null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors