Fix linter: using a local in an assertion.#723
Merged
sbarzowski merged 1 commit intogoogle:masterfrom Jun 10, 2024
Merged
Conversation
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
bejaratommy
pushed a commit
to bejaratommy/go-jsonnet
that referenced
this pull request
Apr 11, 2026
Adds a test case demonstrating that a local variable defined in an outer scope (outside the object) is correctly recognized as used when it appears inside an object-level assert expression. Prevents regression of the fix introduced in google#723. Closes google#778
bejaratommy
added a commit
to bejaratommy/go-jsonnet
that referenced
this pull request
Apr 11, 2026
Adds a test case demonstrating that a local variable defined in an outer scope (outside the object) is correctly recognized as used when it appears inside an object-level assert expression. Prevents regression of the fix introduced in google#723. Closes google#778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #617.
While working on the fix an existing test was discovered that outlines the same bug. It could be fixed after fixing the bug itself.