feat: Add support for bzlmod#698
Conversation
| module_name = "jsonnet", | ||
| remote = "https://github.com/mortenmj/jsonnet.git", | ||
| commit = "df811822d9a31cb3fab9bdf68679ad300f1c12ed", | ||
| ) |
There was a problem hiding this comment.
This would be updated once google/jsonnet#1083 lands, and jsonnet is added to the Bazel Central Registry. This PR is not ready to be merged before that happens.
|
LGTM |
|
Is there any documentation that needs to be updated in either repo? |
|
(Either for people using this or maintaining it) |
|
@sparkprime I am not aware of any documentation that goes into how to import jsonnet/go-jsonnet into a WORKSPACE, but I'd suggest adding similar documentation for using MODULE.bazel. I think it could be a good idea to add a test that shows how this works. This could then also be used in the BCR presubmit.yml, which would add some confidence that we don't break things in the future. Here's an example of what that might look like: |
|
@sparkprime could we merge this? |
* Add support for bzlmod
This PR adds a MODULE.bazel file which allows other repositories to import this one as a bzlmod module.
I don't know how Google handles publishing to the Bazel Central Registry, so I haven't made any attempt at that.
This is ready for review, but not for merging, pending google/jsonnet#1083 which adds bzlmod support for jsonnet. Jsonnet would need to be added to the Bazel Central Registry for this PR to be merged, as bzlmod does not allow importing modules that use overrides (such as
git_overrideused here).Update: Jsonnet has been merged into BCR, so this can move forward.