feat!: Add ListReactionOptions to all ListxxReactions functions to enable filter by content#3532
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3532 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 184 184
Lines 16143 16143
=======================================
Hits 14739 14739
Misses 1230 1230
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @colbylwilliams!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
|
Thank you, @stevehipwell! |
BREAKING CHANGE:
ListCommentReactionOptions=>ListReactionOptionsand allList*Reactionsmethods now use it.All list reactions endpoint now suppor the
contentquery parameters to filter the returned results by content (+1,eyes, etc.). Including:This PR updates all
ListxxReactionsfunctions corresponding to the APIs above, replacing the genericListOptionswithListReactionOptionswhich contains theContentfield.Note on breaking changes:
ListCommentReactionsalready utilzed a options param struct:ListCommentReactionOptions. This PR replaces that withListReactionOptionsto maintain consistency. This change and all theListOptionsshould be considered breaking.