chore!: Add sliceofpointers custom linter #3447
Merged
gmlewis merged 10 commits intogoogle:masterfrom Jan 22, 2025
Merged
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
…inter Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3447 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 179 179
Lines 15532 15532
=======================================
Hits 14139 14139
Misses 1221 1221
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
7 tasks
ldez
suggested changes
Jan 21, 2025
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
sliceofpointers custom linter
Collaborator
Author
|
@stevehipwell - do you have time for a code review? Thank you! |
Contributor
|
I'm curious: what is the reasoning behind using slice of pointer of struct inside of slice of struct? |
ldez
approved these changes
Jan 22, 2025
Collaborator
Author
|
Collaborator
Author
|
Thank you, @ldez! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ListOAuthAppsnow returns([]*OAuthApp, error)instead of([]OAuthApp, error).This PR should help developers use a consistent style by not writing
[]*stringor[]Tin their PRs.It should also ease the maintenance burden by not having to repeat this over and over again.