Skip to content

gen-accessors: update dumping of getters#3437

Merged
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:update-gen-accessors-dump
Jan 16, 2025
Merged

gen-accessors: update dumping of getters#3437
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:update-gen-accessors-dump

Conversation

@alexandear
Copy link
Copy Markdown
Contributor

@alexandear alexandear commented Jan 16, 2025 •
edited
Loading

After merging this PR, the checks for #3433 will become green (I checked here).

The PR addresses the issue described in #3433 (comment): we need to guarantee the order of equal getters.

func (s *SMTP) GetUsername() string {
	if s == nil || s.Username == nil {
		return ""
	}
	return *s.Username
}

// GetUserName returns the UserName field if it's non-nil, zero value otherwise.
func (s *SMTP) GetUserName() string {
	if s == nil || s.UserName == nil {
		return ""
	}
	return *s.UserName
}

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (ec4431e).
Report is 223 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3437      +/-   ##
==========================================
- Coverage   97.72%   92.26%   -5.46%     
==========================================
  Files         153      174      +21     
  Lines       13390    15023    +1633     
==========================================
+ Hits        13085    13861     +776     
- Misses        215     1068     +853     
- Partials       90       94       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis
gmlewis approved these changes Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@gmlewis gmlewis merged commit d13c739 into google:master Jan 16, 2025
@gmlewis gmlewis mentioned this pull request Jan 17, 2025
Merged
@gmlewis gmlewis mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear @gmlewis