feat: Deprecate and replace Bool,Int,Int64,String with Ptr using generics#3355
feat: Deprecate and replace Bool,Int,Int64,String with Ptr using generics#3355gmlewis merged 3 commits intogoogle:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3355 +/- ##
==========================================
- Coverage 97.72% 92.27% -5.45%
==========================================
Files 153 176 +23
Lines 13390 15033 +1643
==========================================
+ Hits 13085 13872 +787
- Misses 215 1068 +853
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
|
I have mixed feelings about this change. While I'm a huge fan of generics, that would change our base requirements of this repo from a minimum Go version of 1.17 to 1.18, if I'm not mistaken. I have not heard any requests to maintain support for old versions of Go, and we have always officially tested the most recent release of Go and the prior minor version. Let's see if this generates any discussion, pro or con. Meanwhile, if we move forward with this, we should probably convert all the existing usages to |
2dcb9e8 to
adea978
Compare
adea978 to
2a32d65
Compare
2a32d65 to
d2545da
Compare
|
OK, I'm reviewing now. Please refrain from force-pushing if possible, as we always squash-and-merge in this repo so the commit history will be clean, and this will make reviewing changes in the PR much easier for the reviewer(s). Thanks. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging (along with any discussion for or against this change, as usual, of course).
|
Just for the reference: |
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM - But as a caveat I've not reviewed every line of code.
|
@alexandear - hearing no complaints about this PR, and having received one other LGTM (thank you, @stevehipwell !), let's go ahead and move forward with it. |
Merged |
|
Thank you, @alexandear ! |
This PR proposes adding a new helper routine
github.Ptrthat can be used instead of existinggithub.Bool,github.Int,github.Int64,github.String.NOTE that this PR bumps the minimum required version of Go from 1.17 to 1.18.