Skip to content

migrate to github.com/moby/moby modules#2228

Merged
jonjohnsonjr merged 2 commits intogoogle:mainfrom
thaJeztah:migrate_moby
Mar 12, 2026
Merged

migrate to github.com/moby/moby modules#2228
jonjohnsonjr merged 2 commits intogoogle:mainfrom
thaJeztah:migrate_moby

Conversation

@thaJeztah
Copy link
Copy Markdown
Contributor

No description provided.

@thaJeztah
Copy link
Copy Markdown
Contributor Author

/cc @jonjohnsonjr perhaps you can give CI a kick to see if it all works; this was all mostly "mechanical" to update for the new signatures 😅

@thaJeztah thaJeztah marked this pull request as ready for review March 6, 2026 23:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.21%. Comparing base (8b3c303) to head (3530064).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
pkg/v1/daemon/options.go 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8b3c303) and HEAD (3530064). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8b3c303) HEAD (3530064)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2228       +/-   ##
===========================================
- Coverage   71.67%   53.21%   -18.47%     
===========================================
  Files         123      164       +41     
  Lines        9935    10986     +1051     
===========================================
- Hits         7121     5846     -1275     
- Misses       2115     4433     +2318     
- Partials      699      707        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Subserial
Copy link
Copy Markdown
Contributor

Running go mod tidy on the root should allow the presubmit to pass.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Contributor Author

Thx! @jonjohnsonjr @Subserial think go.mod should be good now

@jonjohnsonjr jonjohnsonjr merged commit e916301 into google:main Mar 12, 2026
17 checks passed
@thaJeztah thaJeztah deleted the migrate_moby branch March 12, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants