Skip to content

crane: fix case in auth response json#2218

Merged
Subserial merged 4 commits intogoogle:mainfrom
aelindeman:patch-1
Feb 24, 2026
Merged

crane: fix case in auth response json#2218
Subserial merged 4 commits intogoogle:mainfrom
aelindeman:patch-1

Conversation

@aelindeman
Copy link
Copy Markdown
Contributor

@aelindeman aelindeman commented Feb 20, 2026

Return title case keys to crane auth get JSON body.

Relates to #2217

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.17%. Comparing base (8b3c303) to head (80aef7a).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
cmd/crane/cmd/auth.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8b3c303) and HEAD (80aef7a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8b3c303) HEAD (80aef7a)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2218       +/-   ##
===========================================
- Coverage   71.67%   53.17%   -18.51%     
===========================================
  Files         123      164       +41     
  Lines        9935    10977     +1042     
===========================================
- Hits         7121     5837     -1284     
- Misses       2115     4433     +2318     
- Partials      699      707        +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Subserial
Copy link
Copy Markdown
Contributor

Subserial commented Feb 23, 2026

@aelindeman looks like the presubmit is asking you to update the command description in:

go-containerregistry/cmd/crane/cmd/auth.go

Lines 142 to 148 in 8e2d6a6

baseCmd := strings.Join(argv, " ")
eg := fmt.Sprintf(` # Read configured credentials for reg.example.com
$ echo "reg.example.com" | %s get
{"username":"AzureDiamond","password":"hunter2"}
# or
$ %s get reg.example.com
{"username":"AzureDiamond","password":"hunter2"}`, baseCmd, baseCmd)
.

@Subserial Subserial merged commit 85f2bf5 into google:main Feb 24, 2026
17 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Subserial Subserial Subserial approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aelindeman @codecov-commenter @Subserial