Skip to content

Don't export whiteouts for single layers#1629

Merged
imjasonh merged 1 commit intogoogle:mainfrom
jonjohnsonjr:whiteouts
Apr 6, 2023
Merged

Don't export whiteouts for single layers#1629
imjasonh merged 1 commit intogoogle:mainfrom
jonjohnsonjr:whiteouts

Conversation

@jonjohnsonjr
Copy link
Copy Markdown
Collaborator

Fixes #1623

Before:

$ crane export quay.io/integreatly/3scale-bundle:v0.8.0 | tar -tv | grep wh
-rwxr-xr-x  0 0      0           0 Dec 31  1969 root/.wh..wh..opq
-rwxr-xr-x  0 0      0           0 Dec 31  1969 metadata/.wh..wh..opq
-rwxr-xr-x  0 0      0           0 Dec 31  1969 manifests/.wh..wh..opq

After:

$ crane export quay.io/integreatly/3scale-bundle:v0.8.0 | tar -tv | grep wh
$

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2023

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.52%. Comparing base (d958444) to head (db05c1a).
⚠️ Report is 163 commits behind head on main.

Files with missing lines Patch % Lines
pkg/v1/types/types.go 0.00% 5 Missing ⚠️
pkg/crane/export.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
- Coverage   72.58%   72.52%   -0.06%     
==========================================
  Files         119      119              
  Lines        9520     9530      +10     
==========================================
+ Hits         6910     6912       +2     
- Misses       1904     1911       +7     
- Partials      706      707       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imjasonh imjasonh merged commit 93be9c4 into google:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ggcr: crane.Export not handling whiteout files in single-layer images

3 participants