Add annotations.proto and generated Go code#5
Merged
Conversation
In order to prepare a PR for google/gnostic#397, gnostic-models needs to be updated to include openapiv3/annotations.proto (and its generated code).
pkwarren
commented
Jul 13, 2023
| // Code generated by protoc-gen-go. DO NOT EDIT. | ||
| // versions: | ||
| // protoc-gen-go v1.27.1 | ||
| // protoc v3.19.3 |
Contributor
Author
There was a problem hiding this comment.
Generated this with the same tool versions used to generate openapiv3/OpenAPIv3.proto code.
| import "openapiv3/OpenAPIv3.proto"; | ||
|
|
||
| // The Go package name. | ||
| option go_package = "./openapiv3;openapi_v3"; |
Contributor
Author
There was a problem hiding this comment.
This is the only change to this file (matching the one made to OpenAPIv3.proto).
Contributor
Author
|
@timburks - Are you the right person to tag for reviews on these PRs? I was hoping to get some feedback on this and the downstream fix in google/gnostic#400 but happy to ping another reviewer. |
Contributor
|
@pkwarren Thanks, AFAIK this is only used by @Jefftree and the k8s team, so since they're ok with google/gnostic#397, I think it's fine to proceed with this. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prepare a PR for
google/gnostic#397, gnostic-models needs to be updated to include openapiv3/annotations.proto (and its generated code).