Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

docs: Correct generation_types.GenerateContentResponse documentation#140

Merged
MarkDaoust merged 1 commit intogoogle-gemini:mainfrom
Hamza-nabil:fix-dooc
Dec 19, 2023
Merged

docs: Correct generation_types.GenerateContentResponse documentation#140
MarkDaoust merged 1 commit intogoogle-gemini:mainfrom
Hamza-nabil:fix-dooc

Conversation

@Hamza-nabil
Copy link
Contributor

@Hamza-nabil Hamza-nabil commented Dec 19, 2023

Description of the change

Remove the async keyword from generation_types.GenerateContentResponse documentation

Motivation

This change is necessary to ensure accurate documentation.

Type of change

Choose one: Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Hamza-nabil Hamza-nabil requested a review from a team as a code owner December 19, 2023 15:03
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 19, 2023
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkDaoust MarkDaoust merged commit 15bc434 into google-gemini:main Dec 19, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 19, 2023
@Hamza-nabil Hamza-nabil deleted the fix-dooc branch December 19, 2023 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants