Merged
Conversation
This was referenced Jun 26, 2024
eliben
approved these changes
Jun 26, 2024
Member
|
Where is the "Also support cached-content token count for CountTokens requests" part of this PR? |
We weren't passing the cached content name in generation or CountTokens requests. Fix that. Also add test for cached-content token count for CountTokens requests (which is skipped because it's not yet implemented in the service).
19e1753 to
184b61d
Compare
Collaborator
Author
|
Good question! It came along for free when we generated the new protos. I just added a test (which doesn't yet work). I updated the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't passing the cached content name in generation or CountTokens
requests. Fix that.
Also support cached-content token count for CountTokens requests
(not yet implemented in the service).