Skip to content

genai: upgrade cloud.google.com/go/ai to v0.7.0#145

Merged
jba merged 1 commit intomainfrom
jba-v070
Jun 25, 2024
Merged

genai: upgrade cloud.google.com/go/ai to v0.7.0#145
jba merged 1 commit intomainfrom
jba-v070

Conversation

@jba
Copy link
Copy Markdown
Collaborator

@jba jba commented Jun 23, 2024

No description provided.

@jba jba requested a review from eliben June 23, 2024 20:01
Copy link
Copy Markdown
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do so many of these PRs update the discovery json files? Is it just an artifact of stacked PRs?

@jba
Copy link
Copy Markdown
Collaborator Author

jba commented Jun 24, 2024

I'm not sure...maybe they change frequently? I've just been ignoring them.

@jba
Copy link
Copy Markdown
Collaborator Author

jba commented Jun 25, 2024

I think it's because I don't fully understand how stacking works. I think PRs are bleeding into each other.
I usually rebase and force push after each merge, so it shouldn't matter.

@jba jba force-pushed the jba-better-generate branch from b6923f4 to 2601569 Compare June 25, 2024 16:57
Base automatically changed from jba-better-generate to main June 25, 2024 17:00
@jba jba merged commit 5592db3 into main Jun 25, 2024
@jba jba deleted the jba-v070 branch June 25, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants