Conversation
Return an error if a conversion fails, instead of panicking. Currently the only possible such failure is when a FunctionResponse contains a value that can't be converted to a Struct proto.
eliben
reviewed
Jun 24, 2024
Member
eliben
left a comment
There was a problem hiding this comment.
Two questions here:
- Shouldn't most of this be shared with vertex? I'm surprised to see
catchPVPanichere and not in shared code - The panic/error flow should be better documented with a comment block somewhere logical that explains what's going on
Collaborator
Author
|
I'll move the catch function to the generated code and also generate a comment for pvPanic. |
Collaborator
Author
|
Done. |
eliben
approved these changes
Jun 25, 2024
kasugamirai
pushed a commit
to kasugamirai/generative-ai-go
that referenced
this pull request
Nov 11, 2025
… Pkl version (google#143) Also: add a trailing newline to `codegen/src/PklProject.deps.json`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error if a conversion fails, instead of panicking.
Currently the only possible such failure is when a FunctionResponse
contains a value that can't be converted to a Struct proto.