Fix documentation#58
Merged
jba merged 4 commits intogoogle:mainfrom Mar 1, 2024
Merged
Conversation
…ation Upgraded Go from version 1.21 to 1.22 and updated various indirect dependencies. Error handling in client_test.go has been enhanced by using the errors.Is function for comparison instead of direct equality check. Fixed minor typos and inconsistencies in the comments of client.go and embed.go.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jba
requested changes
Feb 29, 2024
Collaborator
jba
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
We will accept the documentation fixes. I've commented on other aspects of this PR.
The 'defer' statement in client_test.go has been simplified and doesn't handle error on 'Close()' anymore. Used direct equality comparison instead of 'errors.Is' function for error handling, for checking 'iterator.Done'. Also, downgraded Go version from 1.22 to 1.21.
jba
requested changes
Feb 29, 2024
Contributor
Author
|
Thanks for your suggestion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded Go from version 1.21 to 1.22 and updated various indirect dependencies. Error handling in client_test.go has been enhanced by using the errors.Is function for comparison instead of direct equality check. Fixed minor typos and inconsistencies in the comments of client.go and embed.go.