[C++] Avoid adding semicolon after a statement#8488
Merged
dbaileychess merged 2 commits intogoogle:masterfrom Jan 24, 2025
Merged
[C++] Avoid adding semicolon after a statement#8488dbaileychess merged 2 commits intogoogle:masterfrom
dbaileychess merged 2 commits intogoogle:masterfrom
Conversation
dbaileychess
previously approved these changes
Jan 22, 2025
Collaborator
|
Looks like there is one missing file to update, check here |
Contributor
Author
Thanks. Updated the CL to include that part. |
dbaileychess
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the code generation for C++ object based API (
--gen-object-api), existing code puts a semicolon after a else-statement, and that causes a compiler warning under-Wextra-semi-stmton clang.