use switch statements for BASE_TYPE_ lookups#7813
Merged
dbaileychess merged 1 commit intogoogle:masterfrom Feb 5, 2023
Merged
Conversation
660a167 to
9d0d175
Compare
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
This change is a bug fix in the automatically generated code that was introduced by the new version of the flatbuffer generator that TensorFlow updated to in c17d64d which includes the following change google/flatbuffers#7813 which fixed the underlying flatbuffer code generator bug. PiperOrigin-RevId: 685943323
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
This change is a bug fix in the automatically generated code that was introduced by the new version of the flatbuffer generator that TensorFlow updated to in c17d64d which includes the following change google/flatbuffers#7813 which fixed the underlying flatbuffer code generator bug. PiperOrigin-RevId: 685943323
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
This change is a bug fix in the automatically generated code that was introduced by the new version of the flatbuffer generator that TensorFlow updated to in c17d64d which includes the following change google/flatbuffers#7813 which fixed the underlying flatbuffer code generator bug. PiperOrigin-RevId: 686567841
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
This change is a bug fix in the automatically generated code that was introduced by the new version of the flatbuffer generator that TensorFlow updated to in c17d64d which includes the following change google/flatbuffers#7813 which fixed the underlying flatbuffer code generator bug. PiperOrigin-RevId: 686164263
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since enums are not defined in enum-value order, some of the mapping to arrays were incorrect. Just switch them out for switch statements.
This is not in any performance related area, so going from index to switch statement should not matter.