Skip to content

Fix Bazel ts support#8499

Merged
dbaileychess merged 1 commit intogoogle:masterfrom
mering:fix-bazel-reflection-path
Jan 23, 2025
Merged

Fix Bazel ts support#8499
dbaileychess merged 1 commit intogoogle:masterfrom
mering:fix-bazel-reflection-path

Conversation

@mering
Copy link
Copy Markdown
Contributor

@mering mering commented Jan 22, 2025

Fixes the following error:

LOC/flatbuffers/tests/ts/typescript_keywords.fbs:2: 36: error: unable to load include file: reflection/reflection.fbs

@github-actions github-actions bot added the CI Continuous Integration label Jan 23, 2025
@mering mering changed the title Fix reflection.fbs import path Fix ts support Jan 23, 2025
@mering mering mentioned this pull request Jan 23, 2025
@mering mering marked this pull request as ready for review January 23, 2025 15:56
@mering mering changed the title Fix ts support Fix Bazel ts support Jan 23, 2025
@github-actions github-actions bot removed the CI Continuous Integration label Jan 23, 2025
We need to copy the .fbs files into the package used for .bfbs files.
This is necessary as flatc doesn't provide support to specify the full
output file name for an .fbs file in a different folder.
I tried OUTPUT_FILE env var but this doesn't seem to be honored by
flatc.
@dbaileychess dbaileychess enabled auto-merge (squash) January 23, 2025 19:41
@dbaileychess dbaileychess merged commit 33a15d6 into google:master Jan 23, 2025
@mering mering deleted the fix-bazel-reflection-path branch January 23, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants