Update DefaultCharset.java#4114
Closed
delanym wants to merge 3 commits intogoogle:masterfrom
Closed
Conversation
Prefer (?, Charset) to (?, String) constructor
cushon
requested changes
Sep 24, 2023
Collaborator
cushon
left a comment
There was a problem hiding this comment.
Looks good overall, thanks for the PR.
The tests are currently failing because they are assertion on the old version of the refactoring that included .name(), can you update them?
Fix tests
cushon
requested changes
Sep 24, 2023
cushon
approved these changes
Sep 24, 2023
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Prefer (?, Charset) to (?, String) constructor Such as https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Scanner.html#%3Cinit%3E(java.io.File,java.nio.charset.Charset) Fixes #4114 FUTURE_COPYBARA_INTEGRATE_REVIEW=#4114 from delanym:patch-1 18dbdc4 PiperOrigin-RevId: 568045902
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer (?, Charset) to (?, String) constructor
Such as https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Scanner.html#%3Cinit%3E(java.io.File,java.nio.charset.Charset)