Fix the missing exit code when go test is failed in presubmit script#1008
Merged
roger2hk merged 2 commits intogoogle:masterfrom Dec 11, 2022
Merged
Fix the missing exit code when go test is failed in presubmit script#1008roger2hk merged 2 commits intogoogle:masterfrom
roger2hk merged 2 commits intogoogle:masterfrom
Conversation
2538508 to
daa89b7
Compare
933cdf1 to
7e09625
Compare
AlCutter
approved these changes
Dec 8, 2022
Member
AlCutter
left a comment
There was a problem hiding this comment.
LGTM modulo the golangci bit which I think possibly snuck in here by mistake :)
f265a82 to
7dfcc67
Compare
7dfcc67 to
7f69303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
certificate-transparency-go-cloud-build-pull-request (trillian-opensource-ci)is successfully even the build is failed.--no-generateis added to thePRESUBMIT_OPTSto avoid the generated files are being removed and regenerated during the concurrent tests.The rate limit threshold is increased from
1.01to2to bypass the flakiness infixchain/ratelimiter/limiter_test.go.Checklist