Default enable identifier escaping with backticks#1295
Merged
jnthntatum merged 1 commit intoApr 2, 2026
Conversation
jnthntatum
approved these changes
Apr 2, 2026
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
Apr 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/google/cel-go](https://github.com/google/cel-go) | require | minor | `v0.27.0` → `v0.28.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/google/cel-go) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>google/cel-go (github.com/google/cel-go)</summary> ### [`v0.28.0`](https://github.com/google/cel-go/releases/tag/v0.28.0) [Compare Source](google/cel-go@v0.27.0...v0.28.0) #### High-Level Changes - **Enhanced JSON Interoperability:** New support for JSON names across the checker, AST, and runtime allows for more seamless data handling when working with JSON-native structures. - **Improved Developer Tooling:** Integration is now smoother thanks to new utilities for converting Go errors into `cel.Issues` and more descriptive, context-aware error messages. - **Greater Environment Flexibility:** You can now redeclare variables as constants and export parse limit options, providing finer control over how CEL environments are configured and constrained. - **Native Struct Improvements:** Support for mixing CEL and native values within native structs simplifies the handling of complex, hybrid data types. *** #### 🚀 Features - Add helper method to check whether a function has a singleton binding in [#​1266](google/cel-go#1266) - Helper utility for converting a Go error into `cel.Issues` in [#​1267](google/cel-go#1267) - Policy API improvements in [#​1268](google/cel-go#1268) - CEL Test usability requirements in [#​1269](google/cel-go#1269) - Better context-related error messages in [#​1271](google/cel-go#1271) - Sort `env.Config` values where reasonable in [#​1273](google/cel-go#1273) - Support redeclaring variables as constants in `NewEnv` in [#​1275](google/cel-go#1275) - Add support for exporting parse limit options in [#​1277](google/cel-go#1277) - Support mixing CEL values and native values in native structs in [#​1270](google/cel-go#1270) - Add checker, AST, and type-provider support for JSON names in [#​1283](google/cel-go#1283) - JSON field names runtime support in [#​1286](google/cel-go#1286) - Optionally include reachable fieldpaths in prompt in [#​1285](google/cel-go#1285) - REPL -- cel-spec pb2 and json name support [#​1294](google/cel-go#1294) #### 🐞 Bug Fixes - Fix support for config-based type references in [#​1265](google/cel-go#1265) - Check arg kinds in `optional.or` and `.orValue` impl in [#​1276](google/cel-go#1276) - Bazel fixes for import in [#​1278](google/cel-go#1278) - Support zero-value literals in presence test inlining [#​1280](google/cel-go#1280) - Cache concatList.Size() to prevent O(N^2) evaluation time [#​1291](google/cel-go#1291) - Preserve runtime error node IDs from Resolve [#​1290](google/cel-go#1290) - Default enable identifier escaping with backticks [#​1295](google/cel-go#1295) - Cap format string precision to prevent memory exhaustion [#​1292](google/cel-go#1292) #### 🛠️ Maintenance & Internal - **chore:** Migrate gsutil usage to gcloud storage in [#​1274](google/cel-go#1274) - Lint fixes for exported function/type comments in [#​1279](google/cel-go#1279) - Lint fixes for import in [#​1287](google/cel-go#1287) *** **Full Changelog**: [https://github.com/google/cel-go/compare/v0.27.0...v0.28.0-alpha](https://github.com/google/cel-go/compare/v0.27.0...v0.28.0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday (`* 0-4,22-23 * * 1-5`) - Only on Sunday and Saturday (`* * * * 0,6`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDQuNSIsInVwZGF0ZWRJblZlciI6IjQzLjEwNC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJLaW5kL0RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/402 Co-authored-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space> Co-committed-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space>
dylanratcliffe
pushed a commit
to overmindtech/cli
that referenced
this pull request
May 26, 2026
## Summary - Drop the `replace github.com/google/cel-go => github.com/google/cel-go v0.22.1` in `go.mod`. The protovalidate/kubernetes incompatibility it worked around is gone in the current dep graph. - Bump the direct `github.com/google/cel-go` require from `v0.28.0` (replaced down to v0.22.1, so the require line was a lie) to `v0.28.1`, the current latest. - Drop the matching Renovate `allowedVersions` pin so Renovate stops reverting future bumps. ## Linear Ticket Fixes: [ENG-4231](https://linear.app/overmind/issue/ENG-4231/revisit-cel-go-replace-directive-and-upgrade-to-latest) — Revisit `cel-go` replace directive and upgrade to latest - **Purpose**: Clean up a stale `replace` directive in `go.mod` so authors browsing CEL features stop landing on a 6-version-old API surface. `cel-go` is now a direct dependency of `services/brent-backend/workflows` for the `EventListener`'s `match:` evaluator. - **Blocks**: Not on the critical path; ticket recommends shipping before WA8 (Dogfood Point 1) so the EventListener arrives at customers on a current CEL. ## Changes `go mod graph` confirms the original incompatibility is no longer present: ``` github.com/overmindtech/workspace github.com/google/cel-go@v0.28.0 buf.build/go/protovalidate@v1.2.0 github.com/google/cel-go@v0.28.0 k8s.io/apiserver@v0.35.0 github.com/google/cel-go@v0.26.0 k8s.io/apiextensions-apiserver@v0.35.0 github.com/google/cel-go@v0.26.0 sigs.k8s.io/controller-runtime@v0.23.3 github.com/google/cel-go@v0.26.0 ``` The kubernetes side has moved from "incompatible with anything above v0.22.1" to "happily on v0.26", and the underlying registry-isolation bug was fixed by [bufbuild/protovalidate-go#302](bufbuild/protovalidate-go#302) (shipped in protovalidate v1.2.0, which we already use). MVS resolves to v0.28.1 cleanly with the replace removed. Only one production file uses `cel-go`: `services/brent-backend/workflows/cel_cache.go`. The APIs it touches (`cel.NewEnv`, `cel.Variable`, `cel.ObjectType`, `cel.{String,Dyn}Type`, `cel.CustomTypeAdapter`, `cel.CustomTypeProvider`, `types.NewRegistry`, `types.{Provider,Type,FieldType}`, `ref.Val`) are stable surface area across v0.22 → v0.28. Local checks (all clean): - `go mod tidy` - `go build ./...` - `go test ./services/brent-backend/workflows/...` - `golangci-lint run ./services/brent-backend/workflows/...` The v0.28.0 release enables backtick identifier escaping by default ([cel-go#1295](google/cel-go#1295)). This is additive (unescaped identifiers still work); no shipped CEL expression uses the new syntax. ## Approved Plan - **Plan approver**: Elliot Waddington - **Approval ticket**: https://linear.app/overmind/issue/ENG-4368/approve-revisit-cel-go-replace-directive-and-upgrade-to-latest > Deviation analysis and reviewer assignment are handled automatically by the > pre-approved PR review automation (see docs/PREAPPROVED_CHANGES.md). Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only change: removes a `go.mod` `replace` override for `github.com/google/cel-go` and bumps the module patch version; main risk is subtle behavior differences in CEL parsing/type-checking at runtime. > > **Overview** > Drops the `go.mod` `replace` that forced `github.com/google/cel-go` down to `v0.22.1`, and removes the matching Renovate `allowedVersions` pin so dependency automation can upgrade it going forward. > > Updates the direct `cel-go` requirement from `v0.28.0` to `v0.28.1` and refreshes `go.sum` accordingly (including pruning now-unused transitive entries like `github.com/stoewer/go-strcase`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 717669ce49a234cd44baf46ce60d02a65e26bc06. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com> GitOrigin-RevId: 004bbc0301f0233ba866312fd2f15c376de8074c
tphoney
pushed a commit
to overmindtech/cli
that referenced
this pull request
May 26, 2026
## Summary - Drop the `replace github.com/google/cel-go => github.com/google/cel-go v0.22.1` in `go.mod`. The protovalidate/kubernetes incompatibility it worked around is gone in the current dep graph. - Bump the direct `github.com/google/cel-go` require from `v0.28.0` (replaced down to v0.22.1, so the require line was a lie) to `v0.28.1`, the current latest. - Drop the matching Renovate `allowedVersions` pin so Renovate stops reverting future bumps. ## Linear Ticket Fixes: [ENG-4231](https://linear.app/overmind/issue/ENG-4231/revisit-cel-go-replace-directive-and-upgrade-to-latest) — Revisit `cel-go` replace directive and upgrade to latest - **Purpose**: Clean up a stale `replace` directive in `go.mod` so authors browsing CEL features stop landing on a 6-version-old API surface. `cel-go` is now a direct dependency of `services/brent-backend/workflows` for the `EventListener`'s `match:` evaluator. - **Blocks**: Not on the critical path; ticket recommends shipping before WA8 (Dogfood Point 1) so the EventListener arrives at customers on a current CEL. ## Changes `go mod graph` confirms the original incompatibility is no longer present: ``` github.com/overmindtech/workspace github.com/google/cel-go@v0.28.0 buf.build/go/protovalidate@v1.2.0 github.com/google/cel-go@v0.28.0 k8s.io/apiserver@v0.35.0 github.com/google/cel-go@v0.26.0 k8s.io/apiextensions-apiserver@v0.35.0 github.com/google/cel-go@v0.26.0 sigs.k8s.io/controller-runtime@v0.23.3 github.com/google/cel-go@v0.26.0 ``` The kubernetes side has moved from "incompatible with anything above v0.22.1" to "happily on v0.26", and the underlying registry-isolation bug was fixed by [bufbuild/protovalidate-go#302](bufbuild/protovalidate-go#302) (shipped in protovalidate v1.2.0, which we already use). MVS resolves to v0.28.1 cleanly with the replace removed. Only one production file uses `cel-go`: `services/brent-backend/workflows/cel_cache.go`. The APIs it touches (`cel.NewEnv`, `cel.Variable`, `cel.ObjectType`, `cel.{String,Dyn}Type`, `cel.CustomTypeAdapter`, `cel.CustomTypeProvider`, `types.NewRegistry`, `types.{Provider,Type,FieldType}`, `ref.Val`) are stable surface area across v0.22 → v0.28. Local checks (all clean): - `go mod tidy` - `go build ./...` - `go test ./services/brent-backend/workflows/...` - `golangci-lint run ./services/brent-backend/workflows/...` The v0.28.0 release enables backtick identifier escaping by default ([cel-go#1295](google/cel-go#1295)). This is additive (unescaped identifiers still work); no shipped CEL expression uses the new syntax. ## Approved Plan - **Plan approver**: Elliot Waddington - **Approval ticket**: https://linear.app/overmind/issue/ENG-4368/approve-revisit-cel-go-replace-directive-and-upgrade-to-latest > Deviation analysis and reviewer assignment are handled automatically by the > pre-approved PR review automation (see docs/PREAPPROVED_CHANGES.md). Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk dependency-only change: removes a `go.mod` `replace` override for `github.com/google/cel-go` and bumps the module patch version; main risk is subtle behavior differences in CEL parsing/type-checking at runtime. > > **Overview** > Drops the `go.mod` `replace` that forced `github.com/google/cel-go` down to `v0.22.1`, and removes the matching Renovate `allowedVersions` pin so dependency automation can upgrade it going forward. > > Updates the direct `cel-go` requirement from `v0.28.0` to `v0.28.1` and refreshes `go.sum` accordingly (including pruning now-unused transitive entries like `github.com/stoewer/go-strcase`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 717669ce49a234cd44baf46ce60d02a65e26bc06. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com> GitOrigin-RevId: 004bbc0301f0233ba866312fd2f15c376de8074c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default enable quoted identifiers