Skip to content

Fix the formatting directives to support what's documented in cel-spec#1232

Merged
TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones:fmt-fix
Nov 24, 2025
Merged

Fix the formatting directives to support what's documented in cel-spec#1232
TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones:fmt-fix

Conversation

@TristonianJones
Copy link
Collaborator

The cel-spec formatting docs expect that int, uint are supported with '%e' and '%f' directives as floating point. The code attempts to do this, but failed to convert to floating point resulting in a very unusual text output.

@hudlow
Copy link
Contributor

hudlow commented Nov 18, 2025

IMO, we should have failing conformance tests before this merges.

@TristonianJones TristonianJones requested review from jcking and removed request for jcking November 24, 2025 17:39
@TristonianJones TristonianJones merged commit 6799c15 into google:master Nov 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants