Add AST node IDs to types.Err for errorable expressions#862
Merged
TristonianJones merged 1 commit intogoogle:masterfrom Nov 30, 2023
Merged
Add AST node IDs to types.Err for errorable expressions#862TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones merged 1 commit intogoogle:masterfrom
Conversation
Currently, it is not possible to obtain the source location of a runtime error making it difficult sometimes to identify the cause of an issue. If an AST node ID is available, the source location can be obtained, so add this information to runtime errors. ref.Val values returned by the following types are examined for error state and if an error and no AST node has been set, the node ID of the Interpretable is added to the error. * evalAnd * evalAttr * evalBinary * evalExhaustiveConditional * evalList * evalMap * evalMap * evalObj * evalOr * evalTestOnly * evalUnary * evalVarArgs * evalWatchAttrQual * evalWatchConstQual * evalWatchQual * evalZeroArity
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Nov 29, 2023
Collaborator
TristonianJones
left a comment
There was a problem hiding this comment.
Thanks for the contribution @kortschak!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried to make this as minimally invasive as possible and hopefully the naming is within project style.
Please take a look.
Pull Requests Guidelines
See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.
When creating a new pull request, please fork the repo and work within a
development branch.
Commit Messages
Reviews
Merging
they have write access. Otherwise, the change will be merged by a maintainer.
closes #<issue-num>: descriptionin the merge message,if applicable.