Skip to content

[Web] Wrap webview in a viewgroup to workaround rare crash #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentrengrove merged 1 commit into from
Jan 18, 2023
Merged

[Web] Wrap webview in a viewgroup to workaround rare crash #1483

bentrengrove merged 1 commit into from
Jan 18, 2023

Conversation

@bentrengrove
Copy link
Collaborator

@bentrengrove bentrengrove commented Jan 17, 2023

@bentrengrove bentrengrove force-pushed the ben/wrap_webview_layout branch from f28b105 to 297def9 Compare January 18, 2023 00:02
@bentrengrove bentrengrove merged commit 1a7346f into main Jan 18, 2023
@bentrengrove bentrengrove deleted the ben/wrap_webview_layout branch January 18, 2023 08:20
@KevinnZou
Copy link
Contributor

KevinnZou commented Jun 5, 2023

This change may lead to another issue, the nested scroll does not work now. Since the AndroidViewHolder use view?.isNestedScrollingEnabled to determine whether the child view support nested scroll. It works well before this change because Webview supports nested scroll but failed now since FrameLayout does not. I am wondering if there is any workaround for that problem.

@bentrengrove
Copy link
Collaborator Author

bentrengrove commented Jun 6, 2023

Please open an issue for this and we can investigate

@KevinnZou KevinnZou mentioned this pull request Jun 6, 2023
Closed
@KevinnZou KevinnZou mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IanGClifton IanGClifton IanGClifton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bentrengrove @KevinnZou @IanGClifton