Skip to content

RFC8478 - Add the application/zstd Media Type#75

Merged
ReneWerner87 merged 2 commits intomasterfrom
zstd
Mar 25, 2024
Merged

RFC8478 - Add the application/zstd Media Type#75
ReneWerner87 merged 2 commits intomasterfrom
zstd

Conversation

@gaby
Copy link
Member

@gaby gaby commented Mar 24, 2024 •
edited by coderabbitai bot
Loading

Add application/zstd mime type which uses ".zst" as extension.

Source: https://datatracker.ietf.org/doc/rfc8478/
FastHTTP: valyala/fasthttp#1701
Related: facebook/zstd#767

Summary by CodeRabbit

  • New Features
    • Added support for .zst file MIME type.
  • Tests
    • Improved testing for MIME type detection, including edge cases with file extensions.

@gaby gaby requested a review from a team as a code owner March 24, 2024 20:14
@gaby gaby requested review from ReneWerner87, efectn and sixcolors and removed request for a team March 24, 2024 20:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2024 •
edited
Loading

Walkthrough

The recent update enriches the application's MIME type support by introducing a new entry for .zst files, ensuring proper handling of this compression format. Additionally, the update enhances the robustness of MIME type retrieval by testing the GetMIME function's ability to process file extensions, regardless of whether they are prefixed with a dot.

Changes

Files Change Summary
http.go, http_test.go Added .zst MIME type entry to mimeExtensions in http.go and added tests for GetMIME function in http_test.go

🐰✨
In the code garden, under the moon's soft glow,
A rabbit hopped, with changes in tow.
".zst" now welcomed, with a place to call home,
Tests hopping around, no extension alone.
With each line of code, our world grows more bright,
A digital meadow, bathed in starlight.
🌟📜🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7008899 and 54b11fb.
Files selected for processing (2)
  • http.go (1 hunks)
  • http_test.go (1 hunks)
Additional comments: 1
http.go (1)
  • 235-235: The addition of the .zst MIME type is correctly implemented and aligns with the existing structure of the mimeExtensions map.

coderabbitai[bot]
coderabbitai bot reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 54b11fb and 0d1cbbd.
Files selected for processing (1)
  • http_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • http_test.go

@ReneWerner87 ReneWerner87 merged commit b1e3dbb into master Mar 25, 2024
@efectn efectn deleted the zstd branch March 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@efectn efectn efectn approved these changes

@sixcolors sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

Assignees

No one assigned

Labels

✏️ Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaby @ReneWerner87 @efectn