The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

decoder_test.go (2)

3547-3577: Strengthen multipart assertions and diagnostics; avoid fragile index checks

Make failures more descriptive and robust by comparing slices with reflect.DeepEqual and printing expected vs got. This also avoids potential index issues in future edits. This mirrors prior feedback on similar tests.

Apply this diff:

 func TestDecodeMultipartFiles(t *testing.T) {
+    // t.Parallel() // consider enabling once test stability in parallel is confirmed
     type payload struct {
         Single   *multipart.FileHeader    `schema:"single"`
         Multiple []*multipart.FileHeader  `schema:"multi"`
         PtrSlice *[]*multipart.FileHeader `schema:"ptr"`
     }
@@
     if err := NewDecoder().Decode(&p, src, files); err != nil {
         t.Fatalf("unexpected error: %v", err)
     }
-    if p.Single != fh1 {
-        t.Fatalf("single not set")
-    }
-    if len(p.Multiple) != 2 || p.Multiple[0] != fh1 || p.Multiple[1] != fh2 {
-        t.Fatalf("multi not set")
-    }
-    if p.PtrSlice == nil || len(*p.PtrSlice) != 1 || (*p.PtrSlice)[0] != fh2 {
-        t.Fatalf("ptr slice not set")
-    }
+    if p.Single != fh1 {
+        t.Fatalf("single: got %v, want %v", p.Single, fh1)
+    }
+    expectedMultiple := []*multipart.FileHeader{fh1, fh2}
+    if !reflect.DeepEqual(p.Multiple, expectedMultiple) {
+        t.Fatalf("multi: got %v, want %v", p.Multiple, expectedMultiple)
+    }
+    expectedPtrSlice := []*multipart.FileHeader{fh2}
+    if p.PtrSlice == nil || !reflect.DeepEqual(*p.PtrSlice, expectedPtrSlice) {
+        var got []*multipart.FileHeader
+        if p.PtrSlice != nil {
+            got = *p.PtrSlice
+        }
+        t.Fatalf("ptr slice: got %v, want %v", got, expectedPtrSlice)
+    }
 }

---

3609-3615: Avoid pointer address printing and make slice checks safer

Print values, not pointer addresses, and check the length before dereferencing. This mirrors a previous comment.

Apply this diff:

-    if len(s.N) != 2 || *s.N[0] != 1 || *s.N[1] != 2 {
-        t.Fatalf("unexpected values: %v %v", s.N[0], s.N[1])
-    }
+    if len(s.N) != 2 {
+        t.Fatalf("unexpected slice length: got %d, want 2", len(s.N))
+    }
+    if *s.N[0] != 1 || *s.N[1] != 2 {
+        t.Fatalf("unexpected values: got [%d, %d], want [1, 2]", *s.N[0], *s.N[1])
+    }

decoder_test.go (3)

3579-3588: Assert error type and location for TextUnmarshaler slice failures

Validate MultiError and that the ConversionError is reported on key "b" for stronger guarantees.

Apply this diff:

 func TestDecodeSliceTextUnmarshalerError(t *testing.T) {
     type target struct {
         B []rudeBool `schema:"b"`
     }
 
-    var s target
-    if err := NewDecoder().Decode(&s, map[string][]string{"b": {"maybe"}}); err == nil {
-        t.Fatalf("expected error")
-    }
+    var s target
+    err := NewDecoder().Decode(&s, map[string][]string{"b": {"maybe"}})
+    if err == nil {
+        t.Fatalf("expected error")
+    }
+    me, ok := err.(MultiError)
+    if !ok {
+        t.Fatalf("expected MultiError, got %T: %v", err, err)
+    }
+    if _, ok := me["b"].(ConversionError); !ok {
+        t.Fatalf(`expected ConversionError at key "b", got %T: %v`, me["b"], me["b"])
+    }
 }

---

3623-3626: Assert MultiError and error index for alias slice conversion

For “1,a”, the second element should fail. Asserting the error index makes the test more precise.

Apply this diff:

-    var s target
-    if err := NewDecoder().Decode(&s, map[string][]string{"a": {"1,a"}}); err == nil {
-        t.Fatalf("expected error")
-    }
+    var s target
+    err := NewDecoder().Decode(&s, map[string][]string{"a": {"1,a"}})
+    if err == nil {
+        t.Fatalf("expected error")
+    }
+    me, ok := err.(MultiError)
+    if !ok {
+        t.Fatalf("expected MultiError, got %T: %v", err, err)
+    }
+    ce, ok := me["a"].(ConversionError)
+    if !ok {
+        t.Fatalf(`expected ConversionError at key "a", got %T: %v`, me["a"], me["a"])
+    }
+    if ce.Index != 1 {
+        t.Fatalf("expected failing index 1, got %d", ce.Index)
+    }

---

3547-3549: Run new tests in parallel (t.Parallel) for consistency and speed

Many tests in this file leverage t.Parallel. Consider adding it at the top of each new test for consistency, provided no shared state is impacted.

Example:

 func TestDecodeMultipartFiles(t *testing.T) {
+    t.Parallel()
@@
 }
 
 func TestDecodeSliceTextUnmarshalerError(t *testing.T) {
+    t.Parallel()
@@
 }
 
 func TestDecodeCommaSeparatedZeroEmpty(t *testing.T) {
+    t.Parallel()
@@
 }
 
 func TestDecodeCommaSeparatedPointerSlice(t *testing.T) {
+    t.Parallel()
@@
 }
 
 func TestDecodeCommaSeparatedAliasSliceError(t *testing.T) {
+    t.Parallel()
@@
 }

Also applies to: 3579-3581, 3590-3593, 3605-3608, 3618-3621

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: efectn
PR: gofiber/fiber#3162
File: hooks_test.go:228-228
Timestamp: 2024-12-13T08:14:22.851Z
Learning: In Go test files, prefer using the `require` methods from the `testify` package for assertions instead of manual comparisons and calls to `t.Fatal` or `t.Fatalf`.

Learnt from: sixcolors
PR: gofiber/fiber#2922
File: middleware/cors/utils.go:63-71
Timestamp: 2024-10-08T19:06:06.583Z
Learning: The project uses the testify/assert package for assertions in unit tests.