📚 Docs: Fix typos, and make middleware documentation more consistent#2408
Merged
li-jin-gou merged 2 commits intomasterfrom Apr 10, 2023
unknown repository
Merged
📚 Docs: Fix typos, and make middleware documentation more consistent#2408li-jin-gou merged 2 commits intomasterfrom unknown repository
li-jin-gou merged 2 commits intomasterfrom
unknown repository
Conversation
This fixes several typos in the ISSUE_TEMPLATES, as well as improve their readability, also makes the documentation markdowns more consistent
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Member
|
@cmd777 Can you fix the merge conflict? |
Also removed a TODO comment from monitor.md And fix a typo in timeout.md (depricated).. as well as put it in a caution notice (to make it stand out more)
Author
|
@gaby Yup, It should be OK now. Also, I removed a TODO comment from the monitor.md (figured it's not really that necessary) |
gaby
approved these changes
Apr 9, 2023
efectn
approved these changes
Apr 9, 2023
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes several typos in the ISSUE_TEMPLATES, as well as making the middleware documentation markdowns more consistent
Type of change
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/