🚀 Feature: Public ShutdownWithContext#2407
Merged
li-jin-gou merged 4 commits intogofiber:masterfrom Apr 9, 2023
Merged
Conversation
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
gaby
requested changes
Apr 7, 2023
Member
gaby
left a comment
There was a problem hiding this comment.
Now sure why the spacing was changed in the .md files
Author
it was an auto-formatter in my local.. 😅 |
efectn
approved these changes
Apr 9, 2023
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Fiber app offers two shutdown options:
ShutdownandShutdownWithTimeout. Both of these options internally use a privateshutdownWithContextmethod, which is more versatile for those using Fiber. By makingshutdownWithContextpublic, we allow developers to create the best strategy for shutting down the app.Type of change
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/