Skip to content

bump actions/checkout@v3 and actions/setup-go@v3#1375

Merged
shogo82148 merged 3 commits intomasterfrom
migrate-to-node16-actions
Dec 9, 2022
Merged

bump actions/checkout@v3 and actions/setup-go@v3#1375
shogo82148 merged 3 commits intomasterfrom
migrate-to-node16-actions

Conversation

@shogo82148
Copy link
Copy Markdown
Contributor

Description

Fix warnings in the GitHub Actions workflow.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-go@v2

For example: https://github.com/go-sql-driver/mysql/actions/runs/3562298266

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding cache: true here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but actions/setup-go fails with Go 1.14 when cache: true is enabled.
https://github.com/go-sql-driver/mysql/actions/runs/3574840133/jobs/6010627696

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache option in setup-go uses go.sum file. So we can not use it for now.

I don't know why, but some jobs fail with "Could not get cache folder paths".
This reverts commit 185228e.
@shogo82148 shogo82148 requested a review from methane December 2, 2022 11:41
@shogo82148 shogo82148 merged commit 4591e42 into master Dec 9, 2022
@shogo82148 shogo82148 deleted the migrate-to-node16-actions branch December 9, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants