support Is comparison on MySQLError#1210
Merged
julienschmidt merged 5 commits intogo-sql-driver:masterfrom Jun 3, 2021
Merged
Conversation
Contributor
|
It sounds good. We can drop support Go 1.12 because the latest version of Go is 1.16. |
Member
I think we should drop old versions support now, because we just released v1.6. |
Contributor
|
I dropped support of Go 1.12. #1211 |
Contributor
Author
|
@methane @shogo82148 looks like the PR checks are failing because of a decrease in coverage because of newly "uncovered" lines in rows.go which this PR doesn't touch. Any suggestions how I can work around that? |
methane
reviewed
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for comparison of
MySQLErrorinstances witherrors.Is. This useful for comparing errors (either client-side or server-side) in application code, particularly for things like circuit breakers and retriers.Checklist