Skip to content

improve GitHub Actions workflows#1190

Merged
shogo82148 merged 2 commits intogo-sql-driver:masterfrom
shogo82148:improve-github-actions
Feb 1, 2021
Merged

improve GitHub Actions workflows#1190
shogo82148 merged 2 commits intogo-sql-driver:masterfrom
shogo82148:improve-github-actions

Conversation

@shogo82148
Copy link
Copy Markdown
Contributor

@shogo82148 shogo82148 commented Jan 31, 2021 •
edited
Loading

Description

  • add windows to build matrix
  • use newer versions of MySQL and MariaDB

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@shogo82148
improve GitHub Actions workflows
135caf5 
- add windows to build matrix
- use newer versions of MySQL and MariaDB
methane
methane reviewed Jan 31, 2021
View reviewed changes
.github/workflows/test.yml Outdated
pull_request:
push:
branches:
- "master"
Copy link
Copy Markdown
Member

@methane methane Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why restrict the branch?

When I pushed a new branch to my fork and I want to run test, I need to edit this file.
It is cumbersome.

Copy link
Copy Markdown
Contributor Author

@shogo82148 shogo82148 Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from starter workflows https://github.com/actions/starter-workflows/blob/c59b62dee0eae1f9f368b7011cf05c2fc42cf084/ci/go.yml#L3-L7
but I agree with you, and will remove it.

@shogo82148 shogo82148 requested a review from methane January 31, 2021 13:25
@methane
Copy link
Copy Markdown
Member

methane commented Feb 1, 2021

I'm a little surprised by shell: python, and it is python2. But it's nice than bash.

"shogo82148/actions-setup-mysql@v1" looks great!
I will use it in other projects.

@shogo82148
Copy link
Copy Markdown
Contributor Author

shogo82148 commented Feb 1, 2021

Thank you!

I'm a little surprised by shell: python, and it is python2.

me, too.
ubuntu-20.04 will be the default soon actions/runner-images#1816, and its default python is python 3.
after that, we can use python 3 in shell: python.

@shogo82148 shogo82148 merged commit 4d5208a into go-sql-driver:master Feb 1, 2021
@shogo82148 shogo82148 deleted the improve-github-actions branch February 1, 2021 14:46
@shogo82148 shogo82148 mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shogo82148 @methane