Support returning uint64 from Valuer in ConvertValue#1143
Merged
methane merged 1 commit intogo-sql-driver:masterfrom Aug 13, 2020
Merged
Support returning uint64 from Valuer in ConvertValue#1143methane merged 1 commit intogo-sql-driver:masterfrom
methane merged 1 commit intogo-sql-driver:masterfrom
Conversation
https://golang.org/pkg/database/sql/driver/#Value says: > Value is a value that drivers must be able to handle. It is either nil, a type handled by a database driver's NamedValueChecker interface, or an instance of one of these types:
Contributor
Author
|
Thanks! 😄 |
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
) https://golang.org/pkg/database/sql/driver/#Value says: > Value is a value that drivers must be able to handle. It is either nil, a type handled by a database driver's NamedValueChecker interface, or an instance of one of these types:
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
) https://golang.org/pkg/database/sql/driver/#Value says: > Value is a value that drivers must be able to handle. It is either nil, a type handled by a database driver's NamedValueChecker interface, or an instance of one of these types:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed
ConvertValueimplementation to support returning uint64 fromValuerinterface.https://golang.org/pkg/database/sql/driver/#Value says:
Because this drivers'
NamedValueCheckers (mysqlConnandmysqlStmt) suppotuint64throughConvertValue, we should allowValuerto returnuint64as well.Checklist