Skip to content

fix: response duration for different schemas#71

Merged
VojtechVitek merged 1 commit into
go-chi:masterfrom
JanneAalto:fix/response-duration
Sep 27, 2025
Merged

fix: response duration for different schemas#71
VojtechVitek merged 1 commit into
go-chi:masterfrom
JanneAalto:fix/response-duration

Conversation

@JanneAalto

@JanneAalto JanneAalto commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Fixes: #70

SchemaECS:

{
...,
"event.duration":938083,
...
}

SchemaOTEL:

{
...,
"http.server.request.duration":0.000700583,
...
}

SchemaGCP:

{
...,
"latency":"0.000723667s",
...
}

@VojtechVitek VojtechVitek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good!

I'll be testing this PR in the upcoming weeks. If there's anyone else who'd like to test this too, please let me know.

@JanneAalto

Copy link
Copy Markdown
Contributor Author

@VojtechVitek have you had the time to test this?

@VojtechVitek VojtechVitek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechVitek

Copy link
Copy Markdown
Contributor

Thank you!

@VojtechVitek VojtechVitek merged commit db89bd0 into go-chi:master Sep 27, 2025
@JanneAalto

Copy link
Copy Markdown
Contributor Author

@VojtechVitek can you make a new release from this?

@VojtechVitek

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

event.duration in milliseconds?

2 participants