Support Content-Type headers with charset/boundary parameters#880
Merged
Conversation
Contributor
Author
|
Changed the function parameters, code formatting and inline function. |
VojtechVitek
requested changes
Dec 5, 2023
Closed
VojtechVitek
approved these changes
Sep 18, 2024
VojtechVitek
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for your contribution :)
| if i := strings.Index(s, ";"); i > -1 { | ||
| s = s[0:i] | ||
| } | ||
| s := strings.ToLower(strings.TrimSpace(strings.Split(r.Header.Get("Content-Type"), ";")[0])) |
Contributor
There was a problem hiding this comment.
This doesn't change the behavior (much).
The code is slightly cleaner and can trim whitespaces within first part of the header value.
I'll merge.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I agree that trimming whitespaces and cleaning up the code makes it more efficient and readable. Appreciate you merging the changes!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handler Function Parameters: Changed the function parameters of the returned handler functions to use the http.Handler interface directly. This makes the code more idiomatic and allows for better compatibility with other middleware.
Inline Function Definitions: Eliminated the need for the intermediate fn variable in both SetHeader and AllowContentType functions. You can directly return the http.HandlerFunc in a more concise manner.
Code Comments: Added a comment to explain the splitting of the content type string to extract the MIME type. This improves code readability.
Code Formatting: Applied consistent code formatting to improve readability.