Fix Accept Header to use MediaType.WILDCARD#1318
Merged
jmini merged 1 commit intoMay 2, 2026
Merged
Conversation
- Replaced MediaType.MEDIA_TYPE_WILDCARD with MediaType.WILDCARD as the Accept Header argument for calls to getWithAccepts
jmini
approved these changes
May 2, 2026
jmini
left a comment
Collaborator
There was a problem hiding this comment.
This change looks good to me.
Contributor
Author
|
Thanks for the review @jmini! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request corrects the formatting of the HTTP
Acceptrequest header across multiple request methods to align with requirements defined in RFC 9110 Section 12.5.1.The Jakarta REST API MediaType defines multiple constants including
WILDCARDandMEDIA_TYPE_WILDCARDas follows:MEDIA_TYPE_WILDCARDas*WILDCARDas*/*Several methods in the GitLab4J API used the
MEDIA_TYPE_WILDCARDconstant, resulting in an invalidAcceptheader value of*, which should be limited to subtype references.Following existing usage and aligning with RFC requirements, changing method calls to use the
WILDCARDconstant corrects the behavior and sends*/*as theAcceptheader.