Add fork context warning to validate_secrets.cjs#18523
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update validate_secrets.cjs to include fork context warning
Add fork context warning to validate_secrets.cjs
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds fork context detection to the secret validation script, helping users understand why secrets are missing when running in forked repositories.
Changes:
- Added
isForkRepository()helper function to detect fork repositories from the GitHub context payload - Added a warning message at the start of validation when running in a fork, explaining that parent secrets are not inherited
- Added comprehensive test coverage for the new fork detection logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/setup/js/validate_secrets.cjs | Added isForkRepository() helper function and fork context warning in main() |
| actions/setup/js/validate_secrets.test.cjs | Added 6 test cases for isForkRepository() covering all edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
validate_secrets.cjsruns in a forked repository, all parent secrets are absent, causing every secret to report a generic "not found" error with no hint about the root cause.Changes
validate_secrets.cjs: AddedisForkRepository(payload)pure helper that checkspayload?.repository?.fork === true. Called at the top ofmain()to emit acore.warning()before any per-secret validation when running in a fork:validate_secrets.test.cjs: Added 6 tests forisForkRepositorycoveringfork: true,fork: false, missingforkkey, missingrepositorykey, andnull/undefinedpayload.Original prompt
validate_secrets.cjs#18519💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.