refactor: replace magic numbers with named constants in bodyAllowedForStatus#4529
Merged
appleboy merged 1 commit intogin-gonic:masterfrom Feb 13, 2026
Merged
Conversation
…rStatus Use http.StatusContinue and http.StatusOK instead of hardcoded 100 and 199 for the 1xx informational status range check, consistent with the pattern already used in logger.go. Fixes gin-gonic#4489
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4529 +/- ##
==========================================
- Coverage 99.21% 99.01% -0.21%
==========================================
Files 42 46 +4
Lines 3182 3038 -144
==========================================
- Hits 3157 3008 -149
- Misses 17 21 +4
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
appleboy
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
100and199withhttp.StatusContinueandhttp.StatusOKin thebodyAllowedForStatusfunctionstatus >= http.StatusContinue && status < http.StatusOKinstead ofstatus >= 100 && status <= 199logger.goline 93Fixes #4489
Test plan
go test ./...)bodyAllowedForStatustest cases incontext_test.gocoverhttp.StatusProcessing(1xx),http.StatusNoContent,http.StatusNotModified, andhttp.StatusInternalServerError